Re: New warnings with gcc9

From: Miguel Ojeda
Date: Thu Jan 24 2019 - 10:25:06 EST


Hi Laura,

On Wed, Jan 23, 2019 at 4:27 PM Laura Abbott <labbott@xxxxxxxxxx> wrote:
>
> This looks like we just need to make the attributes match
>
> BUILDSTDERR: lib/crc32.c:209:5: warning: 'crc32_le_base' specifies less restrictive attribute than its target 'crc32_le': 'pure' [-Wmissing-attributes]
> BUILDSTDERR: 209 | u32 crc32_le_base(u32, unsigned char const *, size_t) __alias(crc32_le);
> BUILDSTDERR: | ^~~~~~~~~~~~~
> BUILDSTDERR: lib/crc32.c:195:19: note: 'crc32_le_base' target declared here
> BUILDSTDERR: 195 | u32 __pure __weak crc32_le(u32 crc, unsigned char const *p, size_t len)
> BUILDSTDERR: | ^~~~~~~~
> BUILDSTDERR: lib/crc32.c:210:5: warning: '__crc32c_le_base' specifies less restrictive attribute than its target '__crc32c_le': 'pure' [-Wmissing-attributes]
> BUILDSTDERR: 210 | u32 __crc32c_le_base(u32, unsigned char const *, size_t) __alias(__crc32c_le);
> BUILDSTDERR: | ^~~~~~~~~~~~~~~~
> BUILDSTDERR: lib/crc32.c:200:19: note: '__crc32c_le_base' target declared here
> BUILDSTDERR: 200 | u32 __pure __weak __crc32c_le(u32 crc, unsigned char const *p, size_t len)
> BUILDSTDERR: |

I am sending a patch for these as well, since they are also coming
from -Wmissing-attributes like the others.

Cheers,
Miguel