Re: [PATCH 0/3] kbuild: Add wilddt function instead of listing dtbs
From: Masahiro Yamada
Date: Thu Jan 24 2019 - 11:04:39 EST
On Tue, Jan 22, 2019 at 1:17 AM Leonard Crestez <leonard.crestez@xxxxxxx> wrote:
>
> On 1/7/2019 9:31 PM, Leonard Crestez wrote:
> > The dts makefiles go through a lot of pointless churn when boards are
> > added. Many SOCs (such as imx) have very simple naming conventions for
> > all boards using a certain chip and board listings can be easily
> > collapsed using wildcards.
> >
> > Add a "wilddt" function and use it for imx6/7/8 and layerscape. This can
> > be applied to many other soc families later.
> >
> > Previously sent as RFC: https://lore.kernel.org/patchwork/patch/1022737/
>
> Any feedback? This should be reviewed by kbuild and arm-soc
>
> I think this is a worthwhile cleanup, are there any corner cases or more
> exotic setup I should try in order to validate this series?
Personally, I prefer explicit listing
because I can browse the Makefile to get a quick idea
of which boards are compiled.
I like this to be consistent.
- Exploit wildcard for all platforms
or
- Do not do this at all
But, I am pessimistic about the former
when I look at AT91 platform.
--
Best Regards
Masahiro Yamada