Re: [alsa-devel] [PATCH][next] ASoC: Intel: bytcht_es8316: make mic_name static, reduces object code size

[Pierre-Louis Bossart]

> diff --git a/sound/soc/intel/boards/bytcht_es8316.c b/sound/soc/intel/boards/bytcht_es8316.c
> index fa9c4cf97686..1364e4e601d8 100644
> --- a/sound/soc/intel/boards/bytcht_es8316.c
> +++ b/sound/soc/intel/boards/bytcht_es8316.c
> @@ -437,7 +437,7 @@ static const struct acpi_gpio_mapping byt_cht_es8316_gpios[] = {
>   
>   static int snd_byt_cht_es8316_mc_probe(struct platform_device *pdev)
>   {
> -	const char * const mic_name[] = { "in1", "in2" };
> +	static const char * const mic_name[] = { "in1", "in2" };
>   	struct byt_cht_es8316_private *priv;
>   	struct device *dev = &pdev->dev;
>   	struct snd_soc_acpi_mach *mach;

We have the same code pattern in two other files, so if we care about 
this we should fix it across the board(s), no?

bytcht_es8316.c:ÂÂÂ const char * const mic_name[] = { "in1", "in2" };
bytcr_rt5640.c:ÂÂÂ const char * const map_name[] = { "dmic1", "dmic2", 
"in1", "in3" };
bytcr_rt5651.c:ÂÂÂ const char * const mic_name[] = { "dmic", "in1", 
"in2", "in12" };