Re: [PATCH] s390: hypfs: no need to check return value of debugfs_create functions

From: Heiko Carstens
Date: Fri Jan 25 2019 - 03:48:08 EST


On Tue, Jan 22, 2019 at 04:21:00PM +0100, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Cc: linux-s390@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> arch/s390/hypfs/hypfs.h | 6 +++---
> arch/s390/hypfs/hypfs_dbfs.c | 8 ++------
> arch/s390/hypfs/hypfs_diag.c | 9 ++++-----
> arch/s390/hypfs/hypfs_diag0c.c | 3 ++-
> arch/s390/hypfs/hypfs_sprp.c | 6 +++---
> arch/s390/hypfs/hypfs_vm.c | 3 ++-
> arch/s390/hypfs/inode.c | 11 +++--------
> 7 files changed, 19 insertions(+), 27 deletions(-)

Applied, thanks!