Re: [PATCH 1/4] tty: sisusb_con, convert addr macros to functions

[Greg KH]

On Tue, Jan 22, 2019 at 04:26:12PM +0100, Jiri Slaby wrote:
> On 22. 01. 19, 16:23, Greg KH wrote:
> > On Tue, Jan 22, 2019 at 04:11:59PM +0100, Jiri Slaby wrote:
> >> Convert SISUSB_VADDR and SISUSB_HADDR to inline functions. Now, there
> >> are no more hidden accesses to local variables (vc_data and
> >> sisusb_usb_data).
> >>
> >> sisusb_haddr returns unsigned long from now on, not u16 *, as ulong is
> >> what every caller expects -- we can remove some casts.
> >>
> >> Call sites were aligned to be readable too.
> >>
> >> Use sisusb_haddr on 4 more places in sisusbcon_blank and
> >> sisusbcon_scroll. It was open coded there with [x, y] being [0, 0].
> >>
> >> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> >> ---
> >>  drivers/usb/misc/sisusbvga/sisusb_con.c | 78 ++++++++++++-------------
> >>  1 file changed, 39 insertions(+), 39 deletions(-)
> > 
> > Subject says "tty", yet this is the USB driver.  typo?
> 
> Originally, I had these as a part of various tty cleanups and the tty
> remained there. I will wait for some feedback, if any and drop them in
> v2.

No problem, I fixed it up and queued it up already, as it looks good,
thanks!

greg k-h