Re: [PATCH v2 3/4] gnss: add mtk receiver type support

From: Johan Hovold
Date: Fri Jan 25 2019 - 04:13:07 EST


On Thu, Jan 17, 2019 at 05:54:33PM +0100, Loys Ollivier wrote:
> Add an MTK (Mediatek) type to the "GNSS_TYPE" attribute.
>
> Note that MTK receivers support a subset of NMEA 0183 with vendor
> extensions (e.g. to allow switching to the vendor protocol).

Copy paste error? AFAICT there is no Mediatek vendor protocol, only the
extensions to NMEA.

> Signed-off-by: Loys Ollivier <lollivier@xxxxxxxxxxxx>
> ---
>
> v2: renamed from GTOP to MTK.
>
> include/linux/gnss.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/gnss.h b/include/linux/gnss.h
> index 43546977098c..36968a0f33e8 100644
> --- a/include/linux/gnss.h
> +++ b/include/linux/gnss.h
> @@ -22,6 +22,7 @@ enum gnss_type {
> GNSS_TYPE_NMEA = 0,
> GNSS_TYPE_SIRF,
> GNSS_TYPE_UBX,
> + GNSS_TYPE_MTK,
>
> GNSS_TYPE_COUNT
> };

Add the gnss_type_names string in this patch along with the define.

Johan