Re: [PATCH v4 2/5] dmaengine: imx-sdma: add imx8mq sdma compatible parts

[Lucas Stach]

Am Donnerstag, den 24.01.2019, 19:55 -0700 schrieb Angus Ainslie (Purism):
> This is identical to the imx7d data structures but we need to
> be able to differentiate that the imx8mq has 2 sdma controllers.

No, we don't, see comment on patch 4/5. This can reuse the imx7d data.

Regards,
Lucas

> Signed-off-by: Angus Ainslie (Purism) <angus@xxxxxxxx>
> ---
> Âdrivers/dma/imx-sdma.c | 10 ++++++++++
> Â1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 5e5ef0b5a973..ec6fb48f387a 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -556,6 +556,12 @@ static struct sdma_driver_data sdma_imx7d = {
> > Â	.script_addrs = &sdma_script_imx7d,
> Â};
> Â
> +static struct sdma_driver_data sdma_imx8mq = {
> > +	.chnenbl0 = SDMA_CHNENBL0_IMX35,
> > +	.num_events = 48,
> > +	.script_addrs = &sdma_script_imx7d,
> +};
> +
> Âstatic const struct platform_device_id sdma_devtypes[] = {
> > Â	{
> > Â		.name = "imx25-sdma",
> @@ -578,6 +584,9 @@ static const struct platform_device_id sdma_devtypes[] = {
> > Â	}, {
> > Â		.name = "imx7d-sdma",
> > Â		.driver_data = (unsigned long)&sdma_imx7d,
> > +	}, {
> > +		.name = "imx8mq-sdma",
> > +		.driver_data = (unsigned long)&sdma_imx8mq,
> > Â	}, {
> > Â		/* sentinel */
> > Â	}
> @@ -592,6 +601,7 @@ static const struct of_device_id sdma_dt_ids[] = {
> > Â	{ .compatible = "fsl,imx31-sdma", .data = &sdma_imx31, },
> > Â	{ .compatible = "fsl,imx25-sdma", .data = &sdma_imx25, },
> > Â	{ .compatible = "fsl,imx7d-sdma", .data = &sdma_imx7d, },
> > +	{ .compatible = "fsl,imx8mq-sdma", .data = &sdma_imx8mq, },
> > Â	{ /* sentinel */ }
> Â};
> ÂMODULE_DEVICE_TABLE(of, sdma_dt_ids);