Re: [PATCH 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support

[Lucas Stach]

Am Freitag, den 18.01.2019, 07:53 +0000 schrieb Aisheng Dong:
> One irqsteer channel can support up to 8 output interrupts.
> 
> > Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> > Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>
> ---
> Â.../devicetree/bindings/interrupt-controller/fsl,irqsteer.txtÂÂÂÂÂÂÂÂ| 5 +++--
> Â1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> index eaabcda..beeed4a 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> @@ -6,8 +6,9 @@ Required properties:
> > Â	- "fsl,imx8m-irqsteer"
> > Â	- "fsl,imx-irqsteer"
> Â- reg: Physical base address and size of registers.
> -- interrupts: Should contain the parent interrupt line used to multiplex the
> -ÂÂinput interrupts.
> +- interrupts: Should contain the up to 8 parent interrupt lines used to
> +ÂÂmultiplex the input interrupts. They should be sepcified seqencially
> +ÂÂfrom output 0 to 7. NOTE at least one output interrupt has to be specified.

I don't think the note clarifies anything. Given that the thing is a
irq multiplexer I don't think anyone expects that you could get away
with no output irq.

If anything this should specify that it's always groups of (up to) 64
input irqs being muxed onto a single output irq.

Regards,
Lucas