Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe

[Jon Hunter]

On 25/01/2019 12:19, Sameer Pujar wrote:
> 
> On 1/25/2019 5:12 PM, Jon Hunter wrote:
>> On 25/01/2019 11:06, Sameer Pujar wrote:
>>> If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks
>>> will not be ON. This could cause issue during probe, where hda init
>>> setup is done. This patch enables clocks unconditionally during probe.
>>>
>>> Along with above, follwoing changes are done.
>>> ÂÂ * enable runtime PM before exiting from probe work. This helps to
>>> avoid
>>> ÂÂÂÂ usage of pm_runtime_get_sync/pm_runtime_put() in probe work.
>>> ÂÂ * hda_tegra_disable_clocks() is moved out of CONFIG_PM_SLEEP check.
>>> ÂÂ * runtime PM callbacks moved out of CONFIG_PM check
>>>
>>> Signed-off-by: Sameer Pujar <spujar@xxxxxxxxxx>
>>> Reviewed-by: Ravindra Lokhande <rlokhande@xxxxxxxxxx>
>>> Reviewed-by: Jon Hunter <jonathanh@xxxxxxxxxx>
>>> ---
>>> Â sound/pci/hda/hda_tegra.c | 26 +++++++++++++++++---------
>>> Â 1 file changed, 17 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c
>>> index c8d18dc..ba6175f 100644
>>> --- a/sound/pci/hda/hda_tegra.c
>>> +++ b/sound/pci/hda/hda_tegra.c
>>> @@ -219,7 +219,6 @@ static int hda_tegra_enable_clocks(struct
>>> hda_tegra *data)
>>> ÂÂÂÂÂ return rc;
>>> Â }
>>> Â -#ifdef CONFIG_PM_SLEEP
>>> Â static void hda_tegra_disable_clocks(struct hda_tegra *data)
>>> Â {
>>> ÂÂÂÂÂ clk_disable_unprepare(data->hda2hdmi_clk);
>>> @@ -227,6 +226,7 @@ static void hda_tegra_disable_clocks(struct
>>> hda_tegra *data)
>>> ÂÂÂÂÂ clk_disable_unprepare(data->hda_clk);
>>> Â }
>>> Â +#ifdef CONFIG_PM_SLEEP
>>> Â /*
>>> ÂÂ * power management
>>> ÂÂ */
>>> @@ -257,7 +257,6 @@ static int hda_tegra_resume(struct device *dev)
>>> Â }
>>> Â #endif /* CONFIG_PM_SLEEP */
>>> Â -#ifdef CONFIG_PM
>>> Â static int hda_tegra_runtime_suspend(struct device *dev)
>>> Â {
>>> ÂÂÂÂÂ struct snd_card *card = dev_get_drvdata(dev);
>>> @@ -283,7 +282,7 @@ static int hda_tegra_runtime_resume(struct device
>>> *dev)
>>> ÂÂÂÂÂ int rc;
>>> Â ÂÂÂÂÂ rc = hda_tegra_enable_clocks(hda);
>>> -ÂÂÂ if (rc != 0)
>>> +ÂÂÂ if (rc)
>>> ÂÂÂÂÂÂÂÂÂ return rc;
>>> ÂÂÂÂÂ if (chip && chip->running) {
>>> ÂÂÂÂÂÂÂÂÂ hda_tegra_init(hda);
>>> @@ -292,7 +291,6 @@ static int hda_tegra_runtime_resume(struct device
>>> *dev)
>>> Â ÂÂÂÂÂ return 0;
>>> Â }
>>> -#endif /* CONFIG_PM */
>>> Â Â static const struct dev_pm_ops hda_tegra_pm = {
>>> ÂÂÂÂÂ SET_SYSTEM_SLEEP_PM_OPS(hda_tegra_suspend, hda_tegra_resume)
>>> @@ -551,9 +549,9 @@ static int hda_tegra_probe(struct platform_device
>>> *pdev)
>>> Â ÂÂÂÂÂ dev_set_drvdata(&pdev->dev, card);
>>> Â -ÂÂÂ pm_runtime_enable(hda->dev);
>>> -ÂÂÂ if (!azx_has_pm_runtime(chip))
>>> -ÂÂÂÂÂÂÂ pm_runtime_forbid(hda->dev);
>>> +ÂÂÂ err = hda_tegra_enable_clocks(hda);
>>> +ÂÂÂ if (err)
>>> +ÂÂÂÂÂÂÂ goto out_free;
>>> Â ÂÂÂÂÂ schedule_work(&hda->probe_work);
>>> Â @@ -571,7 +569,6 @@ static void hda_tegra_probe_work(struct
>>> work_struct *work)
>>> ÂÂÂÂÂ struct platform_device *pdev = to_platform_device(hda->dev);
>>> ÂÂÂÂÂ int err;
>>> Â -ÂÂÂ pm_runtime_get_sync(hda->dev);
>>> ÂÂÂÂÂ err = hda_tegra_first_init(chip, pdev);
>>> ÂÂÂÂÂ if (err < 0)
>>> ÂÂÂÂÂÂÂÂÂ goto out_free;
>>> @@ -592,8 +589,15 @@ static void hda_tegra_probe_work(struct
>>> work_struct *work)
>>> ÂÂÂÂÂ chip->running = 1;
>>> ÂÂÂÂÂ snd_hda_set_power_save(&chip->bus, power_save * 1000);
>>> Â +ÂÂÂ /* set device state as active */
>>> +ÂÂÂ if (pm_runtime_set_active(hda->dev) < 0)
>>> +ÂÂÂÂÂÂÂ goto out_free;
>>> +ÂÂÂ /* enable runtime PM */
>>> +ÂÂÂ pm_runtime_enable(hda->dev);
>>> +ÂÂÂ if (!azx_has_pm_runtime(chip))
>>> +ÂÂÂÂÂÂÂ pm_runtime_forbid(hda->dev);
>>> +
>>> ÂÂ out_free:
>>> -ÂÂÂ pm_runtime_put(hda->dev);
>>> ÂÂÂÂÂ return; /* no error return from async probe */
>>> Â }
>>> Â @@ -603,6 +607,10 @@ static int hda_tegra_remove(struct
>>> platform_device *pdev)
>>> Â ÂÂÂÂÂ ret = snd_card_free(dev_get_drvdata(&pdev->dev));
>>> ÂÂÂÂÂ pm_runtime_disable(&pdev->dev);
>>> +ÂÂÂ if (!pm_runtime_status_suspended(&pdev->dev)) {
>>> +ÂÂÂÂÂÂÂ hda_tegra_runtime_suspend(&pdev->dev);
>>> +ÂÂÂÂÂÂÂ pm_runtime_set_suspended(&pdev->dev);
>>> +ÂÂÂ }
>> I think that we need to be consistent in the above with what is done in
>> the probe. If in the probe we call hda_tegra_enable_clocks(), then here
>> we should call hda_tegra_disable_clocks(). However, my preference is
>> still to all hda_tegra_runtime_resume() in probe and then leave the
>> above as-is. Let's see what everyone else thinks.
> Though it is good to have the handling at a single place, it is slightly
> confusing to call
> runtime_resume() in probe. When runtime PM is not yet enabled, why call
> something that is related
> to it(not logically but intuitively)!

I still don't think that it is confusing, the name of the function is
called hda_tegra_runtime_resume and does what is says on the tin (ie.
resumes the device at runtime).

Furthermore, I think it is completely logical that if pm-runtime is not
enabled, we manually call it. The benefit is that we have single
function for resuming the device for all circumstances.

Cheers
Jon

-- 
nvpublic