Re: [PATCH V4] livepatch: non static warnings fix

From: Jiri Kosina
Date: Fri Jan 25 2019 - 10:44:23 EST


On Thu, 24 Jan 2019, Nicholas Mc Guire wrote:

> Sparse reported warnings about non-static symbols. For the variables
> a simple static attribute is fine - for the functions referenced by
> livepatch via klp_func the symbol-names must be unmodified in the
> symbol table and the patchable code has to be emitted. The resolution
> is to attach __used attribute to the shared statically declared functions.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@xxxxxxxxx>
> Suggested-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx>
> Acked-by: Miroslav Benes <mbenes@xxxxxxx>
> Link: https://lore.kernel.org/lkml/1544965657-26804-1-git-send-email-hofrat@xxxxxxxxx/

I've reordered the tags :) and applied. Thanks,

--
Jiri Kosina
SUSE Labs