Re: [PATCH 1/2] regulator: mc13xxx: Use lowercase regulator names to match the DT

[Vivien Didelot]

Hi Rob,

On Fri, 25 Jan 2019 09:37:04 -0600, Rob Herring <robh@xxxxxxxxxx> wrote:
> Since c32569e358ad ("regulator: Use of_node_name_eq for node name
> comparisons") Vivien reported the mc13892-regulator complaining about
> not being able to find regulators.
> 
> This is because prior to that commit we used of_node_cmp() to compare
> the regulator array passed from mc13892_regulators down to
> mc13xxx_parse_regulators_dt() and they are all defined in uppercase
> letters by the MC13892_*_DEFINE* macros, whereas they are defined as
> lowercase in the DTS.
> 
> Fix this by using a lowercase regulator name to match the DT node name.
> 
> Fixes: c32569e358ad ("regulator: Use of_node_name_eq for node name comparisons")
> Reported-by: Vivien Didelot <vivien.didelot@xxxxxxxxx>
> Reported-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
> Cc: Mark Brown <broonie@xxxxxxxxxx>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
 
This fixes the boot with arch/arm/boot/dts/imx51-zii-rdu1.dts,

Tested-by: Vivien Didelot <vivien.didelot@xxxxxxxxx>


Thanks,

	Vivien