Re: [RFT][PATCH v2] gpiolib: acpi: Introduce ACPI_GPIO_QUIRK_ONLY_GPIOIO

From: Andy Shevchenko
Date: Fri Jan 25 2019 - 12:44:52 EST


On Mon, Jan 21, 2019 at 02:03:09PM +0100, Linus Walleij wrote:
> On Wed, Jan 9, 2019 at 11:52 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> > New quirk enforces search for GPIO based on its type,
> > i.e. iterate over GpioIo resources only.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >
> > - it was sent few weeks ago to Hans for testing, but better to re-test
> > - it's supposed to go via ASoC subsystem due to recent changes made for
> > sound driver
> >
> > v2:
> > - Expand explanation why this quirk might be needed (Mika)
>
> I tried to apply this but it doesn't apply on the GPIO devel
> branch.
>
> I suppose because of Hans de Goede's
> commit 72893f0c6bd399ce84e3c1c9fc69d234fe37d098
> Author: Hans de Goede <hdegoede@xxxxxxxxxx>
> Date: Mon Dec 31 21:55:21 2018 +0100
>
> gpiolib-acpi: Preserve non direction flags when updating gpiod_flags
>
> Could you rebase and resend?

Linus, as I mentioned in comments above this should go via ASoC tree, there is
no conflicts with gpio/devel for GPIO matters.

So, please, give your Ack and hopefully Mark will apply this soon.

>
> (Also pick up Mika's ACK.)
>
> PS I'm a bit split about pure ACPI patches, part of me see it as an
> "intel thing" so that you could very well collect it in the Intel
> GPIO tree and send me pull requests, on the other hand it is
> ACPI and sometimes applied in Rafael's tree. Maybe just as good
> that I keep picking them separately like this?
>
> Yours,
> Linus Walleij

--
With Best Regards,
Andy Shevchenko