Re: [PATCH] KVM: x86: Mark expected switch fall-throughs

[Paolo Bonzini]

On 25/01/19 19:23, Gustavo A. R. Silva wrote:
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index f6915f10e584..1de38062026e 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -1773,7 +1773,7 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>  		if (!msr_info->host_initiated &&
>  		    !guest_cpuid_has(vcpu, X86_FEATURE_RDTSCP))
>  			return 1;
> -		/* Otherwise falls through */
> +		/* Else, falls through */
>  	default:
>  		msr = find_msr_entry(vmx, msr_info->index);
>  		if (msr) {

I would say this is a compiler QoI issue and in general there were other
cases like this one where the comments in the KVM source are reasonable,
but I guess it's okay.  Patch queued.

Paolo