Re: [PATCH] lib/cmdline.c: mark expected switch fall-throughs
From: Gustavo A. R. Silva
Date: Fri Jan 25 2019 - 19:56:16 EST
On 1/25/19 6:18 PM, Kees Cook wrote:
> On Sat, Jan 26, 2019 at 9:31 AM Gustavo A. R. Silva
> <gustavo@xxxxxxxxxxxxxx> wrote:
>>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> lib/cmdline.c:137:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> lib/cmdline.c:140:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> lib/cmdline.c:143:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> lib/cmdline.c:146:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> lib/cmdline.c:149:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
Now applied to for-next/kspp, thanks.
https://git.kernel.org/gustavoars/c/5dd481673c3ddd27d36851754bafbaa82bdff34f
Cheers!
--
Gustavo