Re: + memcg-do-not-report-racy-no-eligible-oom-tasks.patch added to -mm tree
From: Tetsuo Handa
Date: Fri Jan 25 2019 - 20:09:30 EST
On 2019/01/26 3:33, Johannes Weiner wrote:
> On Fri, Jan 25, 2019 at 06:24:16PM +0100, Michal Hocko wrote:
>> On Fri 25-01-19 11:56:24, Johannes Weiner wrote:
>>> It looks like this problem is happening in production systems:
>>>
>>> https://www.spinics.net/lists/cgroups/msg21268.html
>>>
>>> where the threads don't exit because they are trapped writing out the
>>> oom messages to a slow console (running the reproducer from this email
>>> thread triggers the oom flooding).
>>>
>>> So IMO we should put this into 5.0 and add:
>>
>> Please note that Tetsuo has found out that this will not work with the
>> CLONE_VM without CLONE_SIGHAND cases and his http://lkml.kernel.org/r/01370f70-e1f6-ebe4-b95e-0df21a0bc15e@xxxxxxxxxxxxxxxxxxx
>> should handle this case as well. I've only had objections to the
>> changelog but other than that the patch looked sensible to me.
>
> I see. Yeah that looks reasonable to me too.
>
> Tetsuo, could you include the Fixes: and CC: stable in your patch?
>
Andrew Morton is still offline. Do we want to ask Linus Torvalds?