Re: [PATCH v3 2/4] ASoC: add fsl_audmix DT binding documentation
From: Nicolin Chen
Date: Fri Jan 25 2019 - 20:49:28 EST
On Thu, Jan 17, 2019 at 12:46:29PM +0000, Viorel Suman wrote:
> + - dais : Must contain a list of phandles to AUDMIX connected
> + DAIs. The current implementation requires two phandles
> + to SAI interfaces to be provided, the first SAI in the
> + list being used to route the AUDMIX output.
Another small thing, that I just noticed, is this list. It forces
the first input source to be the output source without giving any
chance. I feel that we could have some flexibility here: one node
for two input sources, and one node for the output source.
Well, there is no critical problem with the current binding since
it follows the SoC design. Yet I doubt if this routing logic will
never break.
Any suggestion, Rob?