Re: [PATCH] arm64: dts: allwinner: a64-amarula-relic: Add STLM75 sensor

[Jagan Teki]

On Fri, Jan 25, 2019 at 2:10 PM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
>
> On Thu, Jan 24, 2019 at 11:22:54PM +0530, Jagan Teki wrote:
> > Amarula A64 Relic has STLM75 sensor for digital temperature
> > and thermal watchdog.
> >
> > Add support for it.
> >
> > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> > ---
> > Note: the respective driver change is already in mainline
> > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2e9a41bbc1079776dabe42ed8113b086b99ae56c
> >
> >  .../dts/allwinner/sun50i-a64-amarula-relic.dts    | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> > index 6cb2b7f0c817..5d942543d978 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-amarula-relic.dts
> > @@ -34,6 +34,21 @@
> >       status = "okay";
> >  };
> >
> > +&i2c0 {
> > +     pinctrl-names = "default";
> > +     pinctrl-0 = <&i2c0_pins>;
> > +     status = "okay";
> > +
> > +     temp@48 {
>
> That would be sensor@48
>
> > +             compatible = "st,stlm75";
>
> That compatible isn't documented.

True, but none of the compatible strings used on the driver doesn't
documented in binding instead there are documented in
Documentation/hwmon/lm75.

Don't know the exact reason, do we need to document this in binding as well?