Re: [PATCH v5 0/4] Reduce NUMA related overhead in perf record profiling on large server systems

From: Jiri Olsa
Date: Mon Jan 28 2019 - 03:20:36 EST


On Mon, Jan 28, 2019 at 10:13:20AM +0300, Alexey Budankov wrote:

SNIP

> > ---
> > Alexey Budankov (4):
> > perf record: allocate affinity masks
> > perf record: bind the AIO user space buffers to nodes
> > perf record: apply affinity masks when reading mmap buffers
> > perf record: implement --affinity=node|cpu option
> >
> > tools/perf/Documentation/perf-record.txt | 5 ++
> > tools/perf/builtin-record.c | 45 +++++++++-
> > tools/perf/perf.h | 8 ++
> > tools/perf/util/cpumap.c | 10 +++
> > tools/perf/util/cpumap.h | 1 +
> > tools/perf/util/evlist.c | 6 +-
> > tools/perf/util/evlist.h | 2 +-
> > tools/perf/util/mmap.c | 105 ++++++++++++++++++++++-
> > tools/perf/util/mmap.h | 3 +-
> > 9 files changed, 175 insertions(+), 10 deletions(-)
> >
> > ---
> > Changes in v5:
> > - avoided multiple allocations of online cpu maps by
> > implementing it once in cpu_map__online()
> > - reduced indentation at record__parse_affinity()
>
> Are there any more comments on this patch set?

sry for late reply.. there was a mayhem in here
last week because of the devconf ;-)

I'll review it today, but I think there were no more issues

jirka