Re: [PATCH v9 21/26] irqchip/gic: Add functions to access irq priorities

[Marc Zyngier]

On Mon, 21 Jan 2019 15:33:40 +0000,
Julien Thierry <julien.thierry@xxxxxxx> wrote:
> 
> Add accessors to the GIC distributor/redistributors priority registers.
> 
> Signed-off-by: Julien Thierry <julien.thierry@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
> Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> ---
>  drivers/irqchip/irq-gic-common.c | 10 ++++++++++
>  drivers/irqchip/irq-gic-common.h |  2 ++
>  2 files changed, 12 insertions(+)
> 
> diff --git a/drivers/irqchip/irq-gic-common.c b/drivers/irqchip/irq-gic-common.c
> index 3c93c6f..04eadbc 100644
> --- a/drivers/irqchip/irq-gic-common.c
> +++ b/drivers/irqchip/irq-gic-common.c
> @@ -110,6 +110,16 @@ int gic_configure_irq(unsigned int irq, unsigned int type,
>  	return ret;
>  }
>  
> +void gic_set_irq_prio(unsigned int irq, void __iomem *base, u8 prio)
> +{
> +	writeb_relaxed(prio, base + GIC_DIST_PRI + irq);
> +}
> +
> +u8 gic_get_irq_prio(unsigned int irq, void __iomem *base)
> +{
> +	return readb_relaxed(base + GIC_DIST_PRI + irq);
> +}
> +

Is there a reason why this is in irq-gic-common.c? If we can avoid it,
I'd rather this is made private to GICv3, as I do not intend to
support this for earlier revisions on the architecture.

Thanks,

	M.

-- 
Jazz is not dead, it just smell funny.