Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

From: Andi Kleen
Date: Mon Jan 28 2019 - 12:00:53 EST

Next message: Sasha Levin: "[PATCH AUTOSEL 4.14 079/170] ARM: dts: Fix up the D-Link DIR-685 MTD partition info"
Previous message: Sasha Levin: "[PATCH AUTOSEL 4.14 080/170] tracing: Have trace_stack nr_entries compare not be so subtle"
In reply to: Jiri Olsa: "Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events"
Next in thread: Arnaldo Carvalho de Melo: "Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> > also now it won't make sample for slave events
> > with zero value/period read
> >
> > note the patch needs to be split into more patches,
> > sending it all together for discussion over the solution
>
> any feedback on this one?

Looks good to me.

Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
-Andi