Re: [PATCH AUTOSEL 4.19 033/258] sctp: Fix SKB list traversal in sctp_intl_store_ordered().

From: Marcelo Ricardo Leitner
Date: Mon Jan 28 2019 - 13:09:54 EST


On Mon, Jan 28, 2019 at 10:55:39AM -0500, Sasha Levin wrote:
> From: "David S. Miller" <davem@xxxxxxxxxxxxx>
>
> [ Upstream commit e15e067d0656625c77c52b4e5f0cfbf0c0c3583f ]
>
> Same change as made to sctp_intl_store_reasm().
>
> To be fully correct, an iterator has an undefined value when something
> like skb_queue_walk() naturally terminates.
>
> This will actually matter when SKB queues are converted over to
> list_head.
>
> Formalize what this code ends up doing with the current
> implementation.

Hi Sasha,

This one too then.

Thanks,
Marcelo