Re: [PATCH v2 0/4] crypto: hisilicon: Add HiSilicon QM and ZIP controller driver

[Zhou Wang]

On 2019/1/23 21:08, Zhou Wang wrote:
> This series adds HiSilicon QM and ZIP controller driver in crypto subsystem.
> 
> A simple QM/ZIP driver which helps to provide an example for a general
> accelerator framework is under review in community[1]. Based on this simple
> driver, this series adds HW v2 support, PCI passthrough, reset, PCI/misc error
> handler, debug support. But unlike [1], driver in this patchset only registers
> to crypto subsystem.
> 
> There will be a long discussion about above accelerator framework in the
> process of upstreaming. So let's firstly review and upstream QM/ZIP crypto
> driver.
> 
> Changes v1 -> v2:
> - Change to register zlib/gzip to scomp.
> - Remove hisi_qm_mem_init/uninit, make QM interfaces compact.
> - Some tiny fixes.
> 
> Links:
> - v1  https://lwn.net/Articles/775484/
> - rfc https://lkml.org/lkml/2018/12/13/290
> 
> Reference:
> [1] https://lkml.org/lkml/2018/11/12/1951
> 
> Zhou Wang (4):
>   Documentation: Add debugfs doc for hisi_zip
>   crypto: hisilicon: Add queue management driver for HiSilicon QM module
>   crypto: hisilicon: Add HiSilicon ZIP accelerator support
>   MAINTAINERS: add maintainer for HiSilicon QM and ZIP controller driver
> 
>  Documentation/ABI/testing/debugfs-hisi-zip |   50 +
>  MAINTAINERS                                |    8 +
>  drivers/crypto/hisilicon/Kconfig           |   11 +
>  drivers/crypto/hisilicon/Makefile          |    2 +
>  drivers/crypto/hisilicon/qm.c              | 1736 ++++++++++++++++++++++++++++
>  drivers/crypto/hisilicon/qm.h              |  276 +++++
>  drivers/crypto/hisilicon/zip/Makefile      |    2 +
>  drivers/crypto/hisilicon/zip/zip.h         |   60 +
>  drivers/crypto/hisilicon/zip/zip_crypto.c  |  484 ++++++++
>  drivers/crypto/hisilicon/zip/zip_main.c    | 1199 +++++++++++++++++++
>  10 files changed, 3828 insertions(+)
>  create mode 100644 Documentation/ABI/testing/debugfs-hisi-zip
>  create mode 100644 drivers/crypto/hisilicon/qm.c
>  create mode 100644 drivers/crypto/hisilicon/qm.h
>  create mode 100644 drivers/crypto/hisilicon/zip/Makefile
>  create mode 100644 drivers/crypto/hisilicon/zip/zip.h
>  create mode 100644 drivers/crypto/hisilicon/zip/zip_crypto.c
>  create mode 100644 drivers/crypto/hisilicon/zip/zip_main.c
> 

Any comments for this version?

Best,
Zhou