Re: [PATCH] kprobe: safely access memory specified by userspace

From: Changbin Du
Date: Mon Jan 28 2019 - 22:07:57 EST


Hi,
Please hold until Steven returned from Linux Conf Au. Thanks!

On Tue, Jan 29, 2019 at 12:35:20AM +0000, Sasha Levin wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a -stable tag.
> The stable tag indicates that it's relevant for the following trees: all
>
> The bot has tested the following trees: v4.20.5, v4.19.18, v4.14.96, v4.9.153, v4.4.172, v3.18.133.
>
> v4.20.5: Build OK!
> v4.19.18: Failed to apply! Possible dependencies:
> 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
> 56de76305279 ("tracing: probeevent: Cleanup print argument functions")
> 9178412ddf5a ("tracing: probeevent: Return consumed bytes of dynamic area")
>
> v4.14.96: Failed to apply! Possible dependencies:
> 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function")
> 4bebdc7a85aa ("bpf: add helper bpf_perf_prog_read_value")
> 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
> 908432ca84fc ("bpf: add helper bpf_perf_event_read_value for perf event array map")
> 97562633bcba ("bpf: perf event change needed for subsequent bpf helpers")
> 9802d86585db ("bpf: add a bpf_override_function helper")
> b4da3340eae2 ("tracing/kprobe: bpf: Check error injectable event is on function entry")
> cd86d1fd2102 ("bpf: Adding helper function bpf_getsockops")
> dd0bb688eaa2 ("bpf: add a bpf_override_function helper")
> de8f3a83b0a0 ("bpf: add meta pointer for direct access")
> f3edacbd697f ("bpf: Revert bpf_overrid_function() helper changes.")
>
> v4.9.153: Failed to apply! Possible dependencies:
> 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog")
> 1d9995771fcb ("s390: update defconfigs")
> 23a4e389bdc7 ("nfp: create separate define for max number of vectors")
> 416db5c1e448 ("nfp: remove support for nfp3200")
> 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function")
> 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
> 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme")
> 68453c7a8973 ("nfp: centralize runtime reconfiguration logic")
> 6b0b7551428e ("perf/core: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS")
> 7ff5c83a1deb ("nfp: simplify nfp_net_poll()")
> 9802d86585db ("bpf: add a bpf_override_function helper")
> a4b562bb8ebd ("nfp: use unsigned int for vector/ring counts")
> b4da3340eae2 ("tracing/kprobe: bpf: Check error injectable event is on function entry")
> bf187ea01b07 ("nfp: centralize the buffer size calculation")
> cbeaf7aa733a ("nfp: bring back support for different ring counts")
> ccc109b8ed24 ("net/mlx4_en: Add TX_XDP for CQ types")
> dd0bb688eaa2 ("bpf: add a bpf_override_function helper")
> e390b55d5aef ("bpf: make bpf_xdp_adjust_head support mandatory")
> ecd63a0217d5 ("nfp: add XDP support in the driver")
> f18f97ac43d7 ("tracing/kprobes: Add a helper method to return number of probe hits")
> f3edacbd697f ("bpf: Revert bpf_overrid_function() helper changes.")
>
> v4.4.172: Failed to apply! Possible dependencies:
> 1d9995771fcb ("s390: update defconfigs")
> 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function")
> 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
> 6b0b7551428e ("perf/core: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS")
> 6e127efeeae5 ("s390/config: make the vector optimized crc function builtin")
> a086171ad886 ("s390: Updated kernel config files")
> cb14def6a9ca ("s390/configs: update default configurations")
> e9bc15f28e5f ("s390/config: update default configuration")
> fdcebf6f18ee ("s390/config: Enable config options for Docker")
>
> v3.18.133: Failed to apply! Possible dependencies:
> 1a6877b9c0c2 ("lib: introduce strncpy_from_unsafe()")
> 34c0dad75229 ("s390/hypfs: Add diagnose 0c support")
> 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function")
> 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
> 5a79859ae0f3 ("s390: remove 31 bit support")
> 5c6497c50f8d ("s390/jump label: add sanity checks")
> 6b0b7551428e ("perf/core: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS")
> 8461b63ca01d ("s390: translate cputime magic constants to macros")
> a763bc8b656d ("s390/numa: enable support in s390 configs")
> c07af4f1ce41 ("mm: add missing __PAGETABLE_{PUD,PMD}_FOLDED defines")
> c933146a5e41 ("s390/ftrace,kprobes: allow to patch first instruction")
> d5caa4dbf9bd ("s390/jump label: use different nop instruction")
> e9bc15f28e5f ("s390/config: update default configuration")
> f8b2dcbd9e6d ("s390: add z13 code generation support")
>
>
> How should we proceed with this patch?
>
> --
> Thanks,
> Sasha

--
Cheers,
Changbin Du