Re: [RFC] Don't print sample_type bits in non-group events not set in the group's was Re: [PATCH] perf, script: Fix crash with printing mixed trace point and other events

From: Jiri Olsa
Date: Tue Jan 29 2019 - 04:04:43 EST


On Tue, Jan 29, 2019 at 09:48:51AM +0100, Arnaldo Carvalho de Melo wrote:
> Em Mon, Jan 28, 2019 at 09:00:37AM -0800, Andi Kleen escreveu:
> > > > also now it won't make sample for slave events
> > > > with zero value/period read
> > > >
> > > > note the patch needs to be split into more patches,
> > > > sending it all together for discussion over the solution
> > >
> > > any feedback on this one?
> >
> > Looks good to me.
> >
> > Reviewed-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> > -Andi
>
> Jiri, can you repost with a proper Subject line, Andi's reviewed-by,
> etc?

yes, I need to separate that change also.. just wanted
some ack on the output ;-)

jirka