Re: [PATCH] thermal: bcm2835: Fix crash in bcm2835_thermal_debugfs

[Phil Elwell]

Hi Stefan,

On 29/01/2019 09:44, Stefan Wahren wrote:
> Hi Phil,
> 
> Am 29.01.2019 um 10:10 schrieb Phil Elwell:
>> "cat /sys/kernel/debug/bcm2835_thermal/regset" causes a NULL pointer
>> dereference in bcm2835_thermal_debugfs. The driver makes use of the
>> implementation details of the thermal framework to retrieve a pointer
>> to its private data from a struct thermal_zone_device, and gets it
>> wrong - leading to the crash. Instead, store its private data as the
>> drvdata and retrieve the thermal_zone_device pointer from it.
>>
>> Fixes: bcb7dd9ef206 ("thermal: bcm2835: add thermal driver for bcm2835 SoC")
>>
>> Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx>
> 
> thanks for this patch.
> 
> Could you please resend this patch to the thermal maintainers Zhang Rui and Eduardo Valentin?||||
> 
> Regards
> Stefan
> 

I blame the get_maintainer script - a "Supporter" sounds less invested and less authoritative
than a "Maintainer".

A resend is imminent.

Phil