Re: [PATCH] ARC: [plat-hsdk]: Add support of Vivante GPU

[Lucas Stach]

Am Dienstag, den 29.01.2019, 15:41 +0300 schrieb Eugeniy Paltsev:
> HSDK board has built-in Vivante GPU IP which works perfectly fine
> with Etnaviv driver, so let's use it.
> 
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx>
> ---
> NOTE:
> Â* this patch has prerequisite:
> ÂÂÂhttps://patchwork.kernel.org/patch/10766265/
> 
> Âarch/arc/boot/dts/hsdk.dtsÂÂÂÂÂÂ| 6 ++++++
> Âarch/arc/configs/hsdk_defconfig | 2 +-
> Â2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> index 43f17b51ee89..ef892994f024 100644
> --- a/arch/arc/boot/dts/hsdk.dts
> +++ b/arch/arc/boot/dts/hsdk.dts
> @@ -237,6 +237,12 @@
> > Â				reg = <0>;
> > Â			};
> > Â		};
> +
> > > +		gpu_3d: gpu@90000 {
> > +			compatible = "vivante,gc";
> > +			reg = <0x90000 0x4000>;
> +			interrupts = <28>;

Really no clock inputs? While the driver does not enforce this due to
backward compatibility issues, the binding says that some of the clocks
are mandatory. So I would really like to see them hooked up here, even
if it's just fixed always-on clocks.

Regards,
Lucas

> +		};
> > Â	};
> Â
> > Â	memory@80000000 {
> diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
> index 87b23b7fb781..915e1cca31f8 100644
> --- a/arch/arc/configs/hsdk_defconfig
> +++ b/arch/arc/configs/hsdk_defconfig
> @@ -52,6 +52,7 @@ CONFIG_GPIO_DWAPB=y
> ÂCONFIG_DRM=y
> Â# CONFIG_DRM_FBDEV_EMULATION is not set
> ÂCONFIG_DRM_UDL=y
> +CONFIG_DRM_ETNAVIV=y
> ÂCONFIG_FB=y
> ÂCONFIG_FRAMEBUFFER_CONSOLE=y
> ÂCONFIG_USB_EHCI_HCD=y
> @@ -63,7 +64,6 @@ CONFIG_MMC=y
> ÂCONFIG_MMC_SDHCI=y
> ÂCONFIG_MMC_SDHCI_PLTFM=y
> ÂCONFIG_MMC_DW=y
> -# CONFIG_IOMMU_SUPPORT is not set
> ÂCONFIG_EXT3_FS=y
> ÂCONFIG_VFAT_FS=y
> ÂCONFIG_TMPFS=y