Re: [PATCH] x86/events: Mark expected switch fall-throughs

From: Gustavo A. R. Silva
Date: Tue Jan 29 2019 - 11:20:04 EST




On 1/29/19 10:07 AM, Borislav Petkov wrote:
> On Tue, Jan 29, 2019 at 09:58:05AM -0600, Gustavo A. R. Silva wrote:
>> $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback arch/x86/events/intel/core.c
>
> You need to have -f when supplying a file:
>
> scripts/get_maintainer.pl -f arch/x86/events/intel/core.c
>

You're correct. I used the command I use for patches.

> and the pattern is there:
>
> PERFORMANCE EVENTS SUBSYSTEM
> M: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> ...
> F: arch/*/events/*
>
> yet it still doesn't list Peter as maintainer:
>

Yep. And this is the reason why I didn't include him.

> Thomas Gleixner <tglx@xxxxxxxxxxxxx> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> Ingo Molnar <mingo@xxxxxxxxxx> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT),commit_signer:21/22=95%)
> Borislav Petkov <bp@xxxxxxxxx> (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> "H. Peter Anvin" <hpa@xxxxxxxxx> (reviewer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> x86@xxxxxxxxxx (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT))
> Peter Zijlstra <peterz@xxxxxxxxxxxxx> (commit_signer:19/22=86%,authored:3/22=14%,added_lines:22/382=6%,removed_lines:13/122=11%)
> Kan Liang <kan.liang@xxxxxxxxxxxxxxx> (commit_signer:11/22=50%,authored:10/22=45%,added_lines:144/382=38%,removed_lines:73/122=60%)
> Jiri Olsa <jolsa@xxxxxxxxxx> (commit_signer:4/22=18%,authored:4/22=18%,added_lines:99/382=26%,removed_lines:32/122=26%)
> Andi Kleen <ak@xxxxxxxxxxxxxxx> (added_lines:113/382=30%)
> linux-kernel@xxxxxxxxxxxxxxx (open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)
>
> if you change the pattern to
>
> F: arch/*/events/
>
> i.e., drop the '*', then it works:
>
> $ scripts/get_maintainer.pl -f arch/x86/events/intel/core.c

Yeah. But I don't want to send patches to every person that has touched the file.

> Peter Zijlstra <peterz@xxxxxxxxxxxxx> (supporter:PERFORMANCE EVENTS SUBSYSTEM,commit_signer:19/22=86%,authored:3/22=14%,added_lines:22/382=6%,removed_lines:13/122=11%)
> Ingo Molnar <mingo@xxxxxxxxxx> (supporter:PERFORMANCE EVENTS SUBSYSTEM,commit_signer:21/22=95%)
> Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> (supporter:PERFORMANCE EVENTS SUBSYSTEM)
> Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> (reviewer:PERFORMANCE EVENTS SUBSYSTEM)
> Jiri Olsa <jolsa@xxxxxxxxxx> (reviewer:PERFORMANCE EVENTS SUBSYSTEM,commit_signer:4/22=18%,authored:4/22=18%,added_lines:99/382=26%,removed_lines:32/122=26%)
> Namhyung Kim <namhyung@xxxxxxxxxx> (reviewer:PERFORMANCE EVENTS SUBSYSTEM)
> ...
>

--
Gustavo