Re: [PATCH] regulator: lochnagar: Fix n_voltages setting for VDDCORE

From: Mark Brown
Date: Tue Jan 29 2019 - 13:05:57 EST


On Tue, Jan 29, 2019 at 09:54:38AM +0000, Charles Keepax wrote:

> Hmm... I think this might need a little more investigation, it
> does indeed fail at present (amazing that it works upto exactly 1.2V
> which is common the usecase) but this feels more like a core
> problem. There are indeed only 57 valid voltage settings as the
> range is 0x8 - 0x41, but it seems that presently the core treats
> this less as n_voltages and more like max_selector. Should we
> perhaps be teaching the core to understand the min_selector
> instead?

We've not had a need for this before but that seems like a reasonable
addition.

Attachment: signature.asc
Description: PGP signature