Re: [PATCH v2] dt-bindings: aspeed-lpc: Make parameter optional

[Vijay Khemka]

Thanks Lee,

ïOn 1/29/19, 4:30 AM, "Lee Jones" <lee.jones@xxxxxxxxxx> wrote:

    On Fri, 18 Jan 2019, Vijay Khemka wrote:
    
    > Memory-region and flash phandle is not a required parameter, it is
    > optional to describe in device tree and needed only use basis.
    > 
    > Signed-off-by: Vijay Khemka <vijaykhemka@xxxxxx>
    > ---
    >  Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 3 +++
    >  1 file changed, 3 insertions(+)
    > 
    > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
    > index 34dd89087cff..d28c4e117611 100644
    > --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
    > +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
    > @@ -135,6 +135,9 @@ Required properties:
    >  - clocks:	contains a phandle to the syscon node describing the clocks.
    >  		There should then be one cell representing the clock to use
    >  
    > +Optional properties:
    > +These below properties are optional to define.
    
    This line is superfluous.  Please remove it.
I will remove it. I am assuming only 1 line to remove.
    
    > +
    >  - memory-region: A phandle to a reserved_memory region to be used for the LPC
    >  		to AHB mapping
    >  
    
    -- 
    Lee Jones [æçæ]
    Linaro Services Technical Lead
    Linaro.org â Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog