Re: [PATCH 2/2] regulator: max77650: Convert to use regulator_enable/disable/is_enabled_regmap

[Axel Lin]

Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> æ 2019å1æ30æ éä äå5:12åéï
>
> År., 30 sty 2019 o 10:07 Axel Lin <axel.lin@xxxxxxxxxx> napisaÅ(a):
> >
> > By setting enable_reg, enable_mask, enable_val and disable_val, we can
> > use the regulator_enable/disable/is_enabled_regmap helpers. With this
> > change, then regB field can be removed from struct max77650_regulator_desc.
> >
> > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> > ---
> > Hi Bartosz,
> > I don't have this h/w, please help to review and test it.
> >
> > I think the only difference is the is_enabled checking:
> > Before the patch, it returns en != MAX77650_REGULATOR_DISABLED;
> > After the patch, it returns en == MAX77650_REGULATOR_ENABLED
> > I'm not sure if this difference does matter or not.
> >
>
> NACK. I intend to support the FPS feature of the regulator module in
> the future (see a similar thing in max77620) and I will need to extend
> these callbacks as there will be more possible values here. Regmap
> generics will not be enough.
Got it, thanks for the quick review.