Re: [RFC PATCH 1/5] pci/p2p: add a function to test peer to peer capability

[Christian KÃnig]

Am 29.01.19 um 21:24 schrieb Logan Gunthorpe:
> On 2019-01-29 12:56 p.m., Alex Deucher wrote:
> > On Tue, Jan 29, 2019 at 12:47 PM <jglisse@xxxxxxxxxx> wrote:
> > > From: JÃrÃme Glisse <jglisse@xxxxxxxxxx>
> > >
> > > device_test_p2p() return true if two devices can peer to peer to
> > > each other. We add a generic function as different inter-connect
> > > can support peer to peer and we want to genericaly test this no
> > > matter what the inter-connect might be. However this version only
> > > support PCIE for now.
> > What about something like these patches:
> > https://cgit.freedesktop.org/~deathsimple/linux/commit/?h=p2p&id=4fab9ff69cb968183f717551441b475fabce6c1c
> > https://cgit.freedesktop.org/~deathsimple/linux/commit/?h=p2p&id=f90b12d41c277335d08c9dab62433f27c0fadbe5
> > They are a bit more thorough.
> Those new functions seem to have a lot of overlap with the code that is
> already upstream in p2pdma.... Perhaps you should be improving the
> p2pdma functions if they aren't suitable for what you want already
> instead of creating new ones.

Yeah, well that's what I was suggesting for the very beginning :)

But completely agree the existing functions should be improved instead 
of adding new ones,
Christian.

> Logan
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel