Re: [PATCH v2] venus: enc: fix enum_frameintervals

[Stanimir Varbanov]

Hi Nicolas,

On 1/30/19 5:28 AM, Nicolas Dufresne wrote:
> Le mardi 22 janvier 2019 Ã 12:53 +0200, Stanimir Varbanov a Ãcrit :
>> This ixes an issue when setting the encoder framerate because of
> 
> ixes -> fixes
> 
>> missing precision. Now the frameinterval type is changed to
>> TYPE_CONTINUOUS and step = 1. Also the math is changed when
>> framerate property is called - the firmware side expects that
>> the framerate one is 1 << 16 units.
> 
> Note sure, maybe you didn't mean to add 'one' here ? Why not just say
> that that firmware expect values in Q16 ?

yes, thanks for the suggestion.

> 
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
> 
> Looking toward testing it, but I had the bad luck of using an USB
> storage rootfs, and apparently USB no longer works on 5.0rc+, if you
> have a baseline tree to suggest, I'll take it. Thanks for this patch.

try qcomlt-4.14 release branch at [1].

-- 
regards,
Stan

[1]
https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/log/?h=release/qcomlt-4.14