Re: [PATCH V2 1/4] dt-binding: irq: imx-irqsteer: use irq number instead of group number

[Lucas Stach]

Am Mittwoch, den 30.01.2019, 13:05 +0000 schrieb Aisheng Dong:
> Not all 64 interrupts may be used in one group. e.g. most irqsteer in
> imx8qxp and imx8qm subsystems supports only 32 interrupts.
> 
> As the IP integration parameters are Channel number and interrupts number,
> let's use fsl,num-irqs to represents how many interrupts supported
> by this irqsteer channel.
> 
> > Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> > Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Dong Aisheng <aisheng.dong@xxxxxxx>

As the original fsl,irq-groups was born out of a misunderstanding of
the HW config options and I'm not aware of any users of the current
binding, I'm fine with merging this. I do think this warrants a
backport to stable though, so we don't end up with different bindings
in stable and current kernels.

Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>


> ---
> ChangeLog:
> Âv1->v2:
> Â * change property name fsl,irqs-per-chan to fsl,num-irqs.
> ---
> Â.../devicetree/bindings/interrupt-controller/fsl,irqsteer.txtÂÂÂÂÂÂÂ| 6 +++---
> Â1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> index 45790ce..6d0a41b 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,irqsteer.txt
> @@ -16,8 +16,8 @@ Required properties:
> Â- #interrupt-cells: Specifies the number of cells needed to encode an
> ÂÂÂinterrupt source. The value must be 1.
> Â- fsl,channel: The output channel that all input IRQs should be steered into.
> -- fsl,irq-groups: Number of IRQ groups managed by this controller instance.
> -ÂÂEach group manages 64 input interrupts.
> +- fsl,num-irqs: Number of input interrupts of this channel.
> +ÂÂShould be multiple of 32 input interrupts and up to 512 interrupts.
> Â
> ÂExample:
> Â
> @@ -28,7 +28,7 @@ Example:
> > Â		clocks = <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> > Â		clock-names = "ipg";
> > Â		fsl,channel = <0>;
> > -		fsl,irq-groups = <1>;
> > +		fsl,num-irqs = <64>;
> > Â		interrupt-controller;
> > Â		#interrupt-cells = <1>;
> > Â	};