Re: [PATCH] net: wireless: prefix header search paths with $(srctree)/

From: Hin-Tak Leung
Date: Wed Jan 30 2019 - 10:25:48 EST


--------------------------------------------
On Fri, 25/1/19, Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote:

> Currently, the Kbuild core manipulates header
> search paths in a crazy
> way [1].

> To fix this mess, I want all Makefiles
> to add explicit $(srctree)/ to
> the search paths in the srctree. Some
> Makefiles are already written in
> that way, but not all. The goal of this
> work is to make the notation
> consistent, and finally get rid of the
> gross hacks.

> Having whitespaces after -I does not
> matter since commit 48f6e3cf5bc6
> ("kbuild: do not drop -I without
> parameter").

> I also removed one header search path
> in:

Â
> drivers/net/wireless/broadcom/brcm80211/brcmutil/Makefile

> I was able to compile without it.

> [1]: https://patchwork.kernel.org/patch/9632347/

> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

Acked-by: Hin-Tak Leung <htl10@xxxxxxxxxxxxxxxxxxxxx>

Looks okay for the rtl818x parts.