Re: WARNING in __flush_work
From: Jens Axboe
Date: Wed Jan 30 2019 - 10:53:38 EST
On 1/30/19 6:56 AM, Tetsuo Handa wrote:
> From fd653e8dd0d5368cd0cd9ccd89cf3001e4584f8a Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Date: Wed, 30 Jan 2019 22:21:45 +0900
> Subject: [PATCH] block: pass no-op callback to INIT_WORK().
>
> syzbot is hitting flush_work() warning caused by commit 4d43d395fed12463
> ("workqueue: Try to catch flush_work() without INIT_WORK().") [1].
> Although that commit did not expect INIT_WORK(NULL) case, calling
> flush_work() without setting a valid callback should be avoided anyway.
> Fix this problem by setting a no-op callback instead of NULL.
>
> [1] https://syzkaller.appspot.com/bug?id=e390366bc48bc82a7c668326e0663be3b91cbd29
Applied, thanks.
--
Jens Axboe