RE: [PATCH] nfit: Collect shutdown status for NVDIMM_FAMILY_HYPERV

[Dexuan Cui]

> From: Linux-nvdimm <linux-nvdimm-bounces@xxxxxxxxxxxx> On Behalf Of
> Dexuan Cui
> Sent: Wednesday, January 30, 2019 12:03 PM
> To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Josh Poulson <jopoulso@xxxxxxxxxxxxx>; linux-nvdimm@xxxxxxxxxxxx;
> Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>;
> driverdev-devel@xxxxxxxxxxxxxxxxxxxxxx; Rafael J. Wysocki
> <rjw@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Michael Kelley
> <mikelley@xxxxxxxxxxxxx>; Sasha Levin <Alexander.Levin@xxxxxxxxxxxxx>;
> linux-acpi@xxxxxxxxxxxxxxx; Ross Zwisler <zwisler@xxxxxxxxxx>; Stephen
> Hemminger <sthemmin@xxxxxxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx>
> Subject: RE: [PATCH] nfit: Collect shutdown status for
> NVDIMM_FAMILY_HYPERV
> 
> > From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Sent: Wednesday, January 30, 2019 11:38 AM
> >
> > On Wed, Jan 30, 2019 at 06:48:40PM +0000, Dexuan Cui wrote:
> > >
> > > Let's expose the info to the userspace (e.g. ntctl) via sysfs.
> >
> > If you add a new sysfs file, you need to add a new Documentation/ABI/
> > update as well :(
> 
> It's an existing sysfs node, which was originally added by Dan in Sep 2018:
> /sys/bus/nd/devices/nmem0/nfit/dirty_shutdown.
> 
> Before this patch, the node doesn't appear when Linux runs on Hyper-V,
> and with this patch, the node can appear now.
> 
> However, indeed, the node and the other related nodes have not been
> documented in Documentation/ABI/testing/sysfs-bus-nfit yet.
> I suppose Dan would add that?
Actually the other nodes have been documented, and only the
"dirty_shutdown" is missed. 

It should be straightfoward. Let me make a patch for this.

Thanks for the reminder, Greg!
 
Thanks,
-- Dexuan