Re: [PATCHv6 6/6] coresight: debug: Add Unique Component Identifier (UCI) table

From: Sai Prakash Ranjan
Date: Thu Jan 31 2019 - 19:51:11 EST


On 2/1/2019 6:17 AM, Sai Prakash Ranjan wrote:
On 1/31/2019 11:31 PM, Suzuki K Poulose wrote:


On 31/01/2019 14:22, Sai Prakash Ranjan wrote:
Add UCI table for coresight CPU debug module. This patch adds
the UCI entries for Kryo CPUs found on MSM8996 which shares
the same PIDs as ETMs.

Without this, below error is observed on MSM8996:

nit: Subject doesn't match the patch contents. You could simply say :

coresight: cpu-debug: Add support for Qualcomm Kryo


Done.


diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c
index e8819d750938..915d86a39cee 100644
--- a/drivers/hwtracing/coresight/coresight-cpu-debug.c
+++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c
@@ -655,24 +655,23 @@ static int debug_remove(struct amba_device *adev)
ÂÂÂÂÂ return 0;
 }
+static struct amba_cs_uci_id uci_id_debug[] = {

As Stephen mentioned, this must be "const".

Rest looks fine.

Done.


Also it should be changed in Mike's patch I suppose or else:

In file included from drivers/hwtracing/coresight/coresight-cpu-debug.c:26:0:
drivers/hwtracing/coresight/coresight-cpu-debug.c:672:29: warning: initialization discards âconstâ qualifier from pointer target type [-Wdiscarded-qualifiers]
CS_AMBA_UCI_ID(0x000f0205, uci_id_debug), /* Qualcomm Kryo */
^
drivers/hwtracing/coresight/coresight-priv.h:192:11: note: in definition of macro âCS_AMBA_UCI_IDâ
.data = uci_ptr \
^~~~~~~
drivers/hwtracing/coresight/coresight-cpu-debug.c:673:29: warning: initialization discards âconstâ qualifier from pointer target type [-Wdiscarded-qualifiers]
CS_AMBA_UCI_ID(0x000f0211, uci_id_debug), /* Qualcomm Kryo */
^
drivers/hwtracing/coresight/coresight-priv.h:192:11: note: in definition of macro âCS_AMBA_UCI_IDâ
.data = uci_ptr \
^~~~~~~

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation