Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags

[Xiaqing (A)]

On 2019/2/1 16:15, Dan Carpenter wrote:
> On Fri, Feb 01, 2019 at 02:59:46PM +0800, Qing Xia wrote:
> > In the first loop, gfp_flags will be modified to high_order_gfp_flags,
> > and there will be no chance to change back to low_order_gfp_flags.
> >
> > Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")
>
> Huh...  Presumably you found this bug just by reading the code.  I
> wonder how it affects runtime?
The problem is that when I found that there was no page allocation failure warning
after the failure of the ion alloc in my test, and then I found the problem of gfp_flags.

regards,
Qing

> regards,
> dan carpenter
>
>
> .