Re: [PATCH v3 2/2] arm: dts: gta04: add gps support

[Andreas Kemnade]

On Fri, 1 Feb 2019 11:04:16 +0100
Johan Hovold <johan@xxxxxxxxxx> wrote:

> On Thu, Jan 31, 2019 at 07:06:40PM +0100, Andreas Kemnade wrote:
> > The GTA04 has a w2sg0004 or w2sg0084 gps chip. Not detectable
> > which one is mounted so use the compatibility entry for w2sg0004
> > for all which will work for both.
> > 
> > Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> > ---
> > Changes in v3:
> > - converted to a patchset
> > - added vcc-supply
> > 
> > Changes in v2:
> > - some s/gps/gnss/
> > - not added vcc-supply because the regulator is not modelled
> >   in dts at all
> > 
> > w2sg0004 bindings are in next-20190129
> > 
> >  arch/arm/boot/dts/omap3-gta04.dtsi | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> > index 02d8274a2f47..4ea0f7dc37c6 100644
> > --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> > +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> > @@ -320,6 +320,12 @@  
> >  		>;  
> >         };
> >  
> > +	gps_pins: pinmux_gps_pins {  
> 
> s/gps/gnss/ would be more consistent, but whatever.
> 
well, gps is already in the file at another place. So it is a bit
inconsistent in any case, without further cleanup. If someone comes
up with a strong opinion here I would of course change it.

Regards,
Andreas

Attachment: pgpO64yko345W.pgp
Description: OpenPGP digital signature