[PATCH 4.19 72/74] of: overlay: do not duplicate properties from overlay for new nodes

From: Greg Kroah-Hartman
Date: Mon Feb 04 2019 - 05:49:58 EST

4.19-stable review patch. If anyone has any objections, please let me know.


From: Frank Rowand <frank.rowand@xxxxxxxx>

commit 8814dc46bd9e347d4de55ec5bf8f16ea54470499 upstream.

When allocating a new node, add_changeset_node() was duplicating the
properties from the respective node in the overlay instead of
allocating a node with no properties.

When this patch is applied the errors reported by the devictree
unittest from patch "of: overlay: add tests to validate kfrees from
overlay removal" will no longer occur. These error messages are of
the form:

"OF: ERROR: ..."

and the unittest results will change from:

### dt-test ### end of unittest - 203 passed, 7 failed


### dt-test ### end of unittest - 210 passed, 0 failed

Tested-by: Alan Tull <atull@xxxxxxxxxx>
Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/of/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -393,7 +393,7 @@ static int add_changeset_node(struct ove

if (!tchild) {
- tchild = __of_node_dup(node, node_kbasename);
+ tchild = __of_node_dup(NULL, node_kbasename);
if (!tchild)
return -ENOMEM;