Re: [RFC PATCH v4 06/10] devicetree: bindings: Document first ROHM BD70528 bindings

From: Linus Walleij
Date: Mon Feb 04 2019 - 06:26:03 EST


On Thu, Jan 31, 2019 at 1:04 PM Matti Vaittinen
<matti.vaittinen@xxxxxxxxxxxxxxxxx> wrote:

> Document bindings for regulators (3 bucks, 3 LDOs and 2 LED
> drivers) and 4 GPIO pins which can be configured for I/O or
> as interrupt sources withe configurable trigger levels.
>
> Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
(...)
> +Required properties:
> + - compatible : Should be "rohm,bd70528"
> + - reg : I2C slave address.
> + - interrupts : The interrupt line the device is connected to.
> + - interrupt-controller : To indicate bd70528 acts as an interrupt controller.
> + - #interrupt-cells : Should be 2. usage is compliant to the 2 cells
> + variant of ../interrupt-controller/interrupts.txt
> + - gpio-controller : To indicate bd70528 acts as a gpio controller.
> + - #gpio-cells : Should be 2. The first cell is the pin number and
> + the second cell is used to specify flags. See
> + ../gpio/gpio.txt for more information.
> + - #clock-cells : Should be 0.
> + - regulators: : List of child nodes that specify the regulators.
> + Please see ../regulator/rohm,bd70528-regulator.txt

So if I understand correctly, the clocks and GPIO does not spawn any
child nodes but are attached directly to the MFD node.
This works!
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij