Re: [PATCH v4 12/16] block: sed-opal: unify retrieval of table columns

[Christoph Hellwig]

> +++ b/block/opal_proto.h
> @@ -170,6 +170,8 @@ enum opal_token {
>  	OPAL_READLOCKED = 0x07,
>  	OPAL_WRITELOCKED = 0x08,
>  	OPAL_ACTIVEKEY = 0x0A,
> +	/* lockingsp table */
> +	OPAL_LIFECYCLE = 0x06,

Adding a name for the colum seems independent of the refactoring,
and probably should be a patch of its own.

> -	/* 0x08 is Manufacured Inactive */
> +	/* 0x08 is Manufactured Inactive */

Shouldn't this go into the typo fixes patch at the beginning of
the series?

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>