Re: [PATCHv7] x86/kdump: bugfix, make the behavior of crashkernel=X consistent with kaslr
From: Borislav Petkov
Date: Tue Feb 05 2019 - 03:16:02 EST
On Mon, Feb 04, 2019 at 03:30:16PM -0700, Jerry Hoemann wrote:
> Is your objection only to the second fallback of allocating
> memory above >= 4GB? Or are you objecting to allocating from
> (896 .. 4GB) as well?
My problem is why should the user need to specify high or low allocation
explicitly when we can handle all that in the kernel automatically.
The presence of crashkernel= on the cmdline sure means that the user
wants to allocate memory for a second kernel.
Now, if the requested allocation fails, we say:
Error reserving crashkernel
So, instead of saying that, we can *try* *again* and say
Error reserving requested crashkernel at @..., attempting a high range.
and run memblock_find_in_range() on the other regions which we deemed
are ok to allocate from.
Why aren't we doing that by default instead of placing all those
different options in front of the user and expecting her/him to know
something about all those magic ranges?
I don't think most of the users care about where the kernel gets
allocated - all they want is a working kdump setup.
> Falling back to allocating < 4GB probably satisfes most of the cases
> where the original allocation fails.
Yes. Now make that automatic.
Good mailing practices for 400: avoid top-posting and trim the reply.