Re: [PATCH-next] drm/sun4i: Use PTR_ERR_OR_ZERO in sun8i_phy_clk_create()

From: Chen-Yu Tsai
Date: Tue Feb 05 2019 - 10:08:31 EST


On Sun, Feb 3, 2019 at 8:07 AM Christopher Diaz Riveros
<chrisadr@xxxxxxxxxx> wrote:
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Maxime's reply to the patch "drm/sun4i: hdmi: Use PTR_ERR_OR_ZERO
in sun4i_tmds_create()" [1] probably applies to this one as well:

"""
While this is technically correct (and I appreciate that this is also
a matter of taste), I find the former syntax to be clearer and easier
to extend if needed.
"""

ChenYu

[1] https://patchwork.kernel.org/patch/10671757/