Re: [PATCH v5 13/13] spi: atmel-quadspi: add support for sam9x60 qspi controller

From: Boris Brezillon
Date: Tue Feb 05 2019 - 11:26:47 EST


On Tue, 5 Feb 2019 15:44:04 +0000
<Tudor.Ambarus@xxxxxxxxxxxxx> wrote:

> @@ -450,28 +499,49 @@ static int atmel_qspi_probe(struct
> platform_device *pdev) goto exit;
> }
>
> + aq->caps = of_device_get_match_data(&pdev->dev);
> + if (aq->caps && aq->caps->has_qspick) {

Can we add a caps instance to the sama5d2 entry instead of allowing
caps to be NULL?

The rest looks good to me, feel free to add

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>

on your next version.