Re: [PATCH] zcrypt: handle AP Info notification from CHSC SEI command

From: Tony Krowiak
Date: Tue Feb 05 2019 - 15:27:13 EST


On 2/4/19 5:01 AM, Sebastian Ott wrote:
On Thu, 31 Jan 2019, Tony Krowiak wrote:
On 1/30/19 1:32 PM, Sebastian Ott wrote:
On Wed, 30 Jan 2019, Tony Krowiak wrote:
+++ b/drivers/s390/cio/chsc.h
@@ -9,6 +9,7 @@
#include <asm/chsc.h>
#include <asm/schid.h>
#include <asm/qdio.h>
+#include <asm/ap.h>

This should be moved to chsc.c

I can do that, but I'm curious why.

You only need to include ap.h because of the ap_bus_cfg_chg definition and
you only use that in chsc.c . Other users of chsc.h don't call that
function.

Regards,
Sebastian

Thanks Sebastian, I've made the change and it will be in v2 when I post
it.