Re: [PATCH v1 1/4] clk: qcom: smd: Add XO clock for MSM8998

From: Jeffrey Hugo
Date: Tue Feb 05 2019 - 17:15:25 EST

On 2/5/2019 3:01 PM, Stephen Boyd wrote:
Quoting Jeffrey Hugo (2019-01-30 08:35:44)
The XO clock generally feeds into other clock controllers as the parent
for a lot of clock generators.

Fixes: 6131dc81211c (clk: qcom: smd: Add support for MSM8998 rpm clocks)
Signed-off-by: Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx>

We've historically left out the XO clk because it causes problems where
the XO vote goes away during late init because nobody references it from
the rest of the clk tree and also because RPM defers probe of the system
and then the console blows up when it gets a clk that can't change rate.
See commit 54823af9cd52 ("clk: qcom: Always add factor clock for xo
clocks") for some more info on why we removed all the workarounds and
stuff around here too.

So are you sure this is OK to do?

So, I've got pretty much everything as modules, and I haven't seen any issues. However let me take a look at the commit you point out and see.

Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.