Re: [PATCH] mm/memory-hotplug: Add sysfs hot-remove trigger

From: Robin Murphy
Date: Wed Feb 06 2019 - 15:07:43 EST

On 2019-02-06 6:45 pm, Greg KH wrote:
On Wed, Feb 06, 2019 at 05:03:53PM +0000, Robin Murphy wrote:
ARCH_MEMORY_PROBE is a useful thing for testing and debugging hotplug,
but being able to exercise the (arguably trickier) hot-remove path would
be even more useful. Extend the feature to allow removal of offline
sections to be triggered manually to aid development.

Signed-off-by: Robin Murphy <robin.murphy@xxxxxxx>

This is inspired by a previous proposal[1], but in coming up with a
more robust interface I ended up rewriting the whole thing from
scratch. The lack of documentation is semi-deliberate, since I don't
like the idea of anyone actually relying on this interface as ABI, but
as a handy tool it felt useful enough to be worth sharing :)



drivers/base/memory.c | 42 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 41 insertions(+), 1 deletion(-)

You have to add new Documentation/ABI entries for each new sysfs file
you add :(

Ah, the documentation provided is adapted from the documentation for the existing "probe" attribute it builds upon ;)

But yeah, perhaps I should have tagged this post as an RFC. Much as I dislike it being anywhere near an ABI, if everyone thinks the feature is merge-worthy I'll go ahead and write up some proper doc entries too.