Re: Build regressions/improvements in v5.0-rc5

[Michael Ellerman]

Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes:
> On 2/6/19 2:05 AM, Michael Ellerman wrote:
>> Randy Dunlap <rdunlap@xxxxxxxxxxxxx> writes:
>>> On 2/4/19 9:46 AM, Randy Dunlap wrote:
>>>> On 2/4/19 5:42 AM, Geert Uytterhoeven wrote:
>>>>> Below is the list of build error/warning regressions/improvements in
>>>>> v5.0-rc5[1] compared to v4.20[2].
>>>>>
>>>>> Summarized:
>>>>>   - build errors: +2/-4
>>>>>   - build warnings: +113/-14843
>>>>>
>>>>> JFYI, when comparing v5.0-rc5[1] to v5.0-rc4[3], the summaries are:
>>>>>   - build errors: +0/-0
>>>>>   - build warnings: +56/-59
>>>>>
>>>>> Note that there may be false regressions, as some logs are incomplete.
>>>>> Still, they're build errors/warnings.
>>>>>
>>>>> Happy fixing! ;-)
>>>>>
>>>>> Thanks to the linux-next team for providing the build service.
>>>>>
>>>>> [1] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8834f5600cf3c8db365e18a3d5cac2c2780c81e5/ (238 out of 240 configs)
>>>>> [2] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8fe28cb58bcb235034b64cbbb7550a8a43fd88be/ (all 240 configs)
>>>>> [3] http://kisskb.ellerman.id.au/kisskb/branch/linus/head/f17b5f06cb92ef2250513a1e154c47b78df07d40/ (238 out of 240 configs)
>>>>>
>>>>>
>>>>>
>>>>> *** WARNINGS ***
>>>>>
>>>>> 113 warning regressions:
>>>>
>>>>>   + warning: unmet direct dependencies detected for PPC4xx_PCI_EXPRESS:  => N/A
>>>>
>>>> Hi Geert,
>>>>
>>>> I am trying to find the above warning (needle) in the haystack.
>>>> Can you please direct me to which config/build it is in?
>>>>
>>>> Is there a good way for me to find it?
>>>>
>>>> thanks.
>>>>
>>>
>>> Working backwards, it probably comes from this:
>>>
>>> config CURRITUCK
>>> 	bool "IBM Currituck (476fpe) Support"
>>> 	depends on PPC_47x
>>> 	select SWIOTLB
>>> 	select 476FPE
>>> 	select PPC4xx_PCI_EXPRESS
>>>
>>> This is the only similar Kconfig segment that does not select FORCE_PCI
>>> but PPC4xx_PCI_EXPRESS depends on PCI but
>>> # CONFIG_PCI is not set
>>>
>>> This could be related to a recent series of patches that allows ACPI to
>>> be built without having PCI enabled.
>>>
>>> Michael?
>> 
>> There isn't really an easy way to do it sorry.
>> 
>> If you download the page for the revision:
>>   http://kisskb.ellerman.id.au/kisskb/branch/linus/head/8834f5600cf3c8db365e18a3d5cac2c2780c81e5/
>> 
>> With a lot of grep/sed/awk you can get a list of the URLs for all the
>> builds eg. one would be:
>> 
>>   http://kisskb.ellerman.id.au/kisskb/buildresult/13676551/
>> 
>> And then you can just tack on "log/" to get:
>> 
>>   http://kisskb.ellerman.id.au/kisskb/buildresult/13676551/log/
>> 
>> Which you can wget and grep.
>> 
>> But that's all a bit of a pain.
>> 
>> I have on my todo list to add json formatted build results and revision
>> pages, which would make it quite a bit simpler. But of course I haven't
>> had time to do it yet :/
>
> No problem.
>
> However, I was trying to ask you about the kconfig problem above:
>
>>>>>   + warning: unmet direct dependencies detected for PPC4xx_PCI_EXPRESS
>
> and not the "search the build results" problem.  ;)

Haha, oops :)

A result of the recent rework of the PCI config symbols:

eb01d42a77785ff96b6e66a2a2e7027fc6d78e4a is the first bad commit
commit eb01d42a77785ff96b6e66a2a2e7027fc6d78e4a
Author: Christoph Hellwig <hch@xxxxxx>
Date:   Thu Nov 15 20:05:32 2018 +0100

    PCI: consolidate PCI config entry in drivers/pci
    
    There is no good reason to duplicate the PCI menu in every architecture.
    Instead provide a selectable HAVE_PCI symbol that indicates availability
    of PCI support, and a FORCE_PCI symbol to for PCI on and the handle the
    rest in drivers/pci.
    
    Signed-off-by: Christoph Hellwig <hch@xxxxxx>
    Reviewed-by: Palmer Dabbelt <palmer@xxxxxxxxxx>
    Acked-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
    Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
    Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
    Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
    Acked-by: Paul Burton <paul.burton@xxxxxxxx>
    Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>


But that patch really just exposed an existing problem. CURRITUCK
selects PPC4xx_PCI_EXPRESS which depends on PCI, and PCI is user
selectable in that config.

Previously the powerpc PCI symbol was default y for CURRITUCK so it was
enabled by default and we didn't see a warning.

But a user could always just turn it off and then they'd get the same
warning we're seeing now.

I'll send a patch to force PCI on for CURRITUCK.

cheers