Re: [PATCH v7 05/10] clk: bd718x7: Support ROHM BD70528 clk block

[Matti Vaittinen]

On Wed, Feb 06, 2019 at 09:31:27AM -0800, Stephen Boyd wrote:
> Quoting Matti Vaittinen (2019-02-06 01:39:38)
> > @@ -86,9 +87,21 @@ static int bd71837_clk_probe(struct platform_device *pdev)
> >                 dev_err(&pdev->dev, "No parent clk found\n");
> >                 return -EINVAL;
> >         }
> > -
> > -       c->reg = BD718XX_REG_OUT32K;
> > -       c->mask = BD718XX_OUT32K_EN;
> > +       switch (mfd->chip_type) {
> > +       case ROHM_CHIP_TYPE_BD71837:
> > +       case ROHM_CHIP_TYPE_BD71847:
> > +
> 
> Nitpick: why the extra newline above?
For no obvious reason. I'll fix this as I need to create new version
anyways. I'll squash the first 3 patches and fix some issues pointed out
by the 0-Day test suite.

Br,
	Matti Vaittinen

-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes.  Just then, he vanished ~~~